[PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t
olof at lixom.net
Mon May 14 18:59:46 EDT 2007
On Tue, May 15, 2007 at 08:47:04AM +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2007-05-14 at 15:08 -0700, Andrew Morton wrote:
> > Well that's some pretty sad code you've found there. The kernel
> > surely has
> > some appropriate type to use here without us having to invent a new
> > one.
> > But I suspect if we were to rationalise things in there it will get
> > messy.
> There is more sad stuff involved with drivers assuming IO ports fit in
> int. A proper fix for 2.6.23 will be the rework of PIO allocation I'm
> doing. A temporary fix for 2.6.22 would be for Olof to use
> reserve_phb_iospace() to make sure his PIO gets in the low 31 bits. We
> need to add a spinlock to it though.
Yes, we should do fine with just a 32-bit type and my CF driver being
fixed. I've been travelling and catching up with other things today,
I should have something to post tomorrow.
Andrew, you can drop this patch for now. Sorry for the churn.
More information about the linux-pcmcia