[PATCH] [POWERPC] 8xx: mpc885ads pcmcia support
Vitaly Bordug
vitb at kernel.crashing.org
Sat May 5 19:27:47 EDT 2007
On Fri, 4 May 2007 12:35:43 -0700
Andrew Morton wrote:
> On Fri, 04 May 2007 03:57:51 +0400
> Vitaly Bordug <vitb at kernel.crashing.org> wrote:
>
> >
> > Adds support for PowerQuicc on-chip PCMCIA. The driver is
> > implemented as of_device, so only arch/powerpc stuff is capable to
> > use it, which now implies only mpc885ads reference board.
> >
> > To cope with the code that should be hooked inside driver, but is
> > really board specific (like set_voltage), global structure
> > mpc8xx_pcmcia_ops holds necessary function pointers that are filled
> > in the BSP code.
> >
>
> argh.
>
> akpm:/home/akpm> grep '^.* ' x | wc -l
> 72
>
> please, Linux uses hard-tabs, not
> spacespacespacespacespacespacespacespace everywhere.
>
Whoops. That must've survived being copypasted from the original m8xx_pcmcia.c.
That reminds me to do Lindent on the affected sources but that is subject for another patch.
Sorry for the hassle.
Apparently all the issues were correct, and I'll follow-up with the reworked patch. Thanks for looking at it.
--
Sincerely, Vitaly
More information about the linux-pcmcia
mailing list