if (!pcibios_assign_all_busses()) in parent fixup

Pete Zaitcev zaitcev at redhat.com
Tue Apr 17 15:01:35 EDT 2007


On Tue, 17 Apr 2007 10:29:20 -0700, Kristen Carlson Accardi <kristen.c.accardi at intel.com> wrote:

> > static void __devinit pci_fixup_parent_subordinate_busnr(struct pci_bus *child, int max)
> > {
> > 	/* Attempts to fix that up are really dangerous unless
> > 	   we're going to re-assign all bus numbers. */
> > 	if (!pcibios_assign_all_busses())
> > 		return;

> > I thought about this, and perhaps Jay is right. If we see such a blatant
> > problem, there's no other way but force the subordinate number, right?

> I have to agree that it's dangerous to fixup the subordinate number
> if you aren't assigning all others - otherwise the bios may have assigned
> some number within the secondary->subordinate range to some other bus,
> which will really foul things up.

So I suppose the next step is to identify affected Sager systems with
a DMI scan and set PCI_ASSIGN_ALL_BUSSES with a quirk. If that works
for Disney, would it be acceptable for mainline (until the time when
something is done about 4-bus assumption)?

-- Pete



More information about the linux-pcmcia mailing list