[BUG PCMCIA] 2.6.19-rc5-mm2 broke 3c589_cs.c

[Dominik Brodowski]

Dear Komuro,

On Mon, Nov 20, 2006 at 09:22:28AM +0900, Komuro wrote:
> You remove the "link->conf.Present = parse.config.rmask[0]" from tc589_config.
> 
> But link->conf.Present is also set at tc589_probe,
> so please do not remove this line from tc589_config.
> 
> 
> 
> 
> static int tc589_probe(struct pcmcia_device *link)
> {
> ...
> 
>     link->conf.Present = PRESENT_OPTION;
> 
> ...
> }
> 
> static int tc589_config(struct pcmcia_device *link)
> {
> ...
> 
>     link->conf.Present = parse.config.rmask[0];   <= do not remove!!
> 
> ...
> }

Ah, thanks for noticing this. However, if one removes the
"link->conf.Present" initialization with PRESENT_OPTION, it should work
again, right, for parse.config.rmask[0] overrides PRESENT_OPTION anyways?

Thanks,
	Dominik