[PATCH] AT91RM9200 Compact Flash driver

Dominik Brodowski linux at dominikbrodowski.net
Wed Mar 1 12:48:02 EST 2006


Hi,

On Wed, Mar 01, 2006 at 08:12:31AM -0800, David Brownell wrote:
> On Wednesday 01 March 2006 1:36 am, you wrote:
> 
> > > +	(void) at91_set_A_periph(AT91_PIN_PC9, 0);	/* A25/CFRNW */
> > > +	(void) at91_set_A_periph(AT91_PIN_PC10, 0);	/* NCS4/CFCS */
> > > +	(void) at91_set_A_periph(AT91_PIN_PC11, 0);	/* NCS5/CFCE1 */
> > > +	(void) at91_set_A_periph(AT91_PIN_PC12, 0);	/* NCS6/CFCE2 */
> > 
> > Why do you add "(void)" here before the function call?
> 
> To make it explicit that potential fault codes are being ignored;
> casting into a void is about the simplest convention for that.

OK, that sounds fair. Do you want me to pick up this patch and push it into
2.6.17 via pcmcia-2.6.git?

Thanks,
	Dominik



More information about the linux-pcmcia mailing list