[patch] pcmcia-shutdown-fix.patch

Ingo Molnar mingo at elte.hu
Fri Oct 7 07:09:14 EDT 2005


* Steven Rostedt <rostedt at goodmis.org> wrote:

> Ingo, here's the patch.  This should probably go upstream too since it 
> can happen there too.  The pccardd thread has a race in it that it can 
> shutdown in the TASK_INTERRUPTIBLE state.  Here's the fix.

ah, certainly makes sense. Dominik, does it look good to you too? Patch 
below is for upstream.

	Ingo

----

The pccardd thread has a race in it that it can shutdown in the 
TASK_INTERRUPTIBLE state. Found on the -rt kernel.

From: Steven Rostedt <rostedt at goodmis.org>
Signed-off-by: Ingo Molnar <mingo at elte.hu>

--

 drivers/pcmcia/cs.c |    3 +++
 1 files changed, 3 insertions(+)

Index: linux/drivers/pcmcia/cs.c
===================================================================
--- linux.orig/drivers/pcmcia/cs.c
+++ linux/drivers/pcmcia/cs.c
@@ -689,6 +689,9 @@ static int pccardd(void *__skt)
 		schedule();
 		try_to_freeze();
 	}
+	/* make sure we are running before we exit */
+	set_current_state(TASK_RUNNING);
+
 	remove_wait_queue(&skt->thread_wait, &wait);
 
 	/* remove from the device core */



More information about the linux-pcmcia mailing list