[PATCH] use $devpath instead of $DEVPATH

Colin Watson cjwatson at ubuntu.com
Wed Nov 23 06:58:56 EST 2005


udev documents a $devpath variable, but not $DEVPATH. According to the
code, variable names are parsed case-insensitively at the moment, but
this isn't documented (and Scott James Remnant, who pointed out all the
udev rule issues I'm sending patches for today, thought that only
$devpath would be accepted) so it wouldn't surprise me if this changed.

The following patch changes pcmciautils' udev rules to use the
documented syntax.

--- udev/60-pcmcia.rules
+++ udev/60-pcmcia.rules
@@ -10,7 +10,7 @@
 # However, the "weak" matching by func_id is only allowed _after_ modprobe
 # returns, so that "strong" matches have a higher priority.
 ACTION=="add", SUBSYSTEM=="pcmcia", MODALIAS=="?*", \
-		RUN+="/bin/sh -c 'echo 1 > /sys/$DEVPATH/allow_func_id_match'"
+		RUN+="/bin/sh -c 'echo 1 > /sys/$devpath/allow_func_id_match'"
 
 
 # PCMCIA sockets:

--- udev/60-pcmcia.rules.static
+++ udev/60-pcmcia.rules.static
@@ -10,7 +10,7 @@
 # However, the "weak" matching by func_id is only allowed _after_ modprobe
 # returns, so that "strong" matches have a higher priority.
 ACTION=="add", SUBSYSTEM=="pcmcia", MODALIAS=="?*", \
-		RUN+="/bin/sh -c 'echo 1 > /sys/$DEVPATH/allow_func_id_match'"
+		RUN+="/bin/sh -c 'echo 1 > /sys/$devpath/allow_func_id_match'"
 
 
 # PCMCIA sockets:

Thanks,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]



More information about the linux-pcmcia mailing list