[RFC, PATCH] pcmcia/yenta: make bridge specific init code configurable

Matthew Wilcox matthew at wil.cx
Thu Nov 3 16:04:52 EST 2005


On Thu, Nov 03, 2005 at 12:45:28PM -0800, Pete Zaitcev wrote:
> On Thu, 3 Nov 2005 21:12:14 +0100, Daniel Ritz <daniel.ritz-ml at swissonline.ch> wrote:
> 
> > [ i never said it's pretty...to much preprocessor crap in a .c...but still ]
> 
> Looks ok to me, actually. The brackets are not deeply embedded into
> nested blocks, and are uniform.

Yes.  I think the bigger problem with yenta's structure is all these
functions in header files.  I couldn't see how it could possibly make a
difference to comment out what was commented until I looked in the .h
files and realised what's going on.

However, I don't see a better way of doing it.  So yuck, but no concrete
suggestions for improvement.



More information about the linux-pcmcia mailing list