[PATCH 12/14] pcmcia: request CIS via firmware interface

[Dominik Brodowski]

On Thu, Mar 03, 2005 at 01:10:35AM +0100, Marcel Holtmann wrote:
> Hi Dominik,
> 
> > > > Use the firmware method to load replacement CIS tables. It is recommended
> > > > that the /lib/firmware/cis/ points to /etc/pcmcia/cis or the other way round
> > > > so that both old-style cardmgr and new-style hotplug/firmware can access
> > > > these "overwrite" files
> > > 
> > > do we really need the "cis" subdirectory? I don't see any need for it
> > > and actually using the suffix .cis looks a lot more sane to me.
> > 
> > Well, we do not really _need_ it, but having a symlink from
> > /lib/firmware/cis/ to /etc/pcmcia/cis and keeping the current names from
> > pcmcia-cs allows us to share using this between cardmgr and in-kernel.
> 
> we can symlink every single CIS file or install them twice.
> 
> > However, I don't care all that much, so I'd like to get some more input on
> > this from others.
> 
> Basically the request_firmware() was not designed to handle directories
> or subdirectories. It is working, but I think the kernel should not
> demand the naming of a subdirectory. The userspace chooses the place for
> the firmware files. The kernel only gives an image name.

OK, you convinced me.

Thanks,
	Dominik