[PATCH] Removal of unused version information

Dominik Brodowski linux at dominikbrodowski.net
Thu Jun 30 17:59:33 EDT 2005


Hi,

Good patch, I mostly agree with it, but...

> @@ -81,16 +79,11 @@ static int pcmcia_get_card_services_info

as the function seems unused in-kernel and in userspace utilites, please
remove it completely. Especially this call here needs to go:

> --- a/drivers/scsi/pcmcia/nsp_cs.c
> +++ b/drivers/scsi/pcmcia/nsp_cs.c
> @@ -2159,10 +2159,6 @@ static int __init nsp_cs_init(void)
>  
>  	nsp_msg(KERN_INFO, "loading...");
>  	pcmcia_get_card_services_info(&serv);
> -	if (serv.Revision != CS_RELEASE_CODE) {
> -		nsp_msg(KERN_DEBUG, "Card Services release does not match!");
> -		return -EINVAL;
> -	}

Thanks,
	Dominik



More information about the linux-pcmcia mailing list