grey- and blacklisting drivers [Was: Re: Using the "best available" driver]

[Dominik Brodowski]

Hi,

On Tue, Dec 13, 2005 at 05:55:04AM +0100, Kay Sievers wrote:
> New version, which does not do the dirty "default parameters" trick. It
> depends on a regular module parameter, if "bind_mode" control at module
> load or boot prompt is needed. It uses "auto" and "manual" as the values
> and the sysfs file in the driver directory is called "bind_mode".

Great, many thanks!

> index 036c485..3f31c2a 100644
> --- a/drivers/usb/media/ov511.c
> +++ b/drivers/usb/media/ov511.c
> @@ -84,6 +84,10 @@
>   * (See ov511.txt for detailed descriptions of these)
>   **********************************************************************/
>  
> +static char bind_mode[8];
> +module_param_string(bind_mode, bind_mode, sizeof(bind_mode), 0);
> +

The only thing which worries me is that we add quite some bytes to the
kernel here... What do you think about this?

#define module_param_bind_mode(driver)					\
	module_param_named(dont_bind, &driver->bind_mode, uint, 0);	\
	MODULE_PARM_DESC(bind_mode, "Do not bind this driver to "	\
				"devices automatically.");

Then we'd need to add

module_param_named(&ov511_driver.driver);

to ov511.c and get the same functionality.


Thanks,
	Dominik