cardmgr: Endless loop with SD-Card

[Dominik Brodowski]

Hi,

On Fri, Apr 22, 2005 at 11:34:26PM +0200, Hadmut Danisch wrote:
> Hi,
> 
> with some help the problem with the PCMCIA-Slot driven by 
> a Ricoh Co Ltd RL5c476 II  was solved (see the kernel bug 4501). 
> 
> But now there is another problem: 
> 
> The SD-Card-Slot is driven by the same chip. Since there is only 
> one PCMCIA slot, I guess the SD/MMC/MS-Slot takes the place of the
> second PCMCIA slot.
> 
> As soon as I insert an SD-Card, the cardmgr goes into an endless loop:

This patch, which is already merged in 2.6.12-rc2, should fix it:


Properly set the return value for DS_BIND_MTD, DS_GET_FIRST_REGION and
DS_GET_NEXT_REGION. Else trying to bind MTD devices the old (deprecated)
way may cause an endless loop in cardmgr. This also happens if the
resources weren't made available properly in /etc/pcmcia/config.opts.

Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>
---

 drivers/pcmcia/ds.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: 2.6.12-rc1/drivers/pcmcia/ds.c
===================================================================
--- 2.6.12-rc1.orig/drivers/pcmcia/ds.c	2005-03-19 10:15:23.000000000 +0100
+++ 2.6.12-rc1/drivers/pcmcia/ds.c	2005-03-19 10:18:33.000000000 +0100
@@ -1453,7 +1453,7 @@
 			printed++;
 		}
 	}
-	ret = -EINVAL;
+	err = -EINVAL;
 	goto free_out;
 	break;
     case DS_GET_FIRST_WINDOW: