[PATCHES] move code for !STATIC_MAP to extra module

Dominik Brodowski linux at dominikbrodowski.de
Mon Nov 8 02:07:01 EST 2004


On Sun, Nov 07, 2004 at 07:48:33PM -0800, David Hinds wrote:
> On Sun, Nov 07, 2004 at 10:51:02PM +0100, Dominik Brodowski wrote:
> > 
> > Yes, they still need to be managed. However, AFAICS not by "mem_db" and
> > "io_db", but by managing them in cs.c -- code which I haven't touched yet.
> > Or do I miss something here?
> 
> You're correct that io_db and mem_db are not needed.  But cs.c relies
> on find_io_region() to resolve resource conflicts, and that needs to
> be available for the static socket case.
>
> Err actually now that I look at it, the code in the kernel's cs.c is
> broken, because as you noted in your original message, it is not using
> find_io_region() for static mapped sockets as it should.

However, if io_db isn't needed and thus isn't filled with content, 
find_io_region will always fail! (both in pcmcia-cs-3.2.7 and in the
kernel's version).

So I think if something is needed it needs to be different from the "nonstatic"
find_io_region version. 

	Dominik



More information about the linux-pcmcia mailing list