[PATCH 6/3] obsole pcmica/memory.h

[Dominik Brodowski]

On Thu, Mar 25, 2004 at 03:42:06PM -0500, Pavel Roskin wrote:
> On Thu, 25 Mar 2004, Dominik Brodowski wrote:
> 
> > #include <pcmcia/memory.h> cannot be found anywhere in the Linux kernel
> > source, so mark it OBSOLETE
> 
> Why not just put #warning into that file?  I understand you want to
> discourage independent PCMCIA drivers from using that file. Suppose a
> driver includes pcmcia/memory.h but doesn't need it.  Then the driver
> developers won't notice the problem early.

If they don't read the help text, yes... you're right, a #warning makes
sense in both pcmcia/memory.h and pcmcia/ftl.h. Patch [depends on previous
patches] attached.

> By the way, I hope you are not removing support for pcmciamtd.

If you mean drivers/mtd/.../pcmciamtd.c, definitely not. I'm not touching
any drivers [yet], and any functions _used_ by any in-kernel PCMCIA driver
isn't marked OBSOLETE.

	Dominik

Add warning so that people using pcmcia/{memory,ftl}.h speak up before these
files are removed from the kernel sources.

 include/pcmcia/ftl.h    |    2 ++
 include/pcmcia/memory.h |    2 ++
 2 files changed, 4 insertions(+)

diff -ruN linux-original/include/pcmcia/ftl.h linux/include/pcmcia/ftl.h
--- linux-original/include/pcmcia/ftl.h	2004-03-25 20:53:39.383790176 +0100
+++ linux/include/pcmcia/ftl.h	2004-03-25 21:59:34.482523776 +0100
@@ -32,6 +32,8 @@
 
 #ifdef CONFIG_PCMCIA_OBSOLETE
 
+#warning external driver uses include/pcmcia/ftl.h. Please report to linux-pcmcia at lists.infradead.org
+
 typedef struct erase_unit_header_t {
     u_char	LinkTargetTuple[5];
     u_char	DataOrgTuple[10];
diff -ruN linux-original/include/pcmcia/memory.h linux/include/pcmcia/memory.h
--- linux-original/include/pcmcia/memory.h	2004-03-25 21:58:38.073099312 +0100
+++ linux/include/pcmcia/memory.h	2004-03-25 21:59:17.768064760 +0100
@@ -32,6 +32,8 @@
 
 #ifdef CONFIG_PCMCIA_OBSOLETE
 
+#warning external driver uses include/pcmcia/memory.h. Please report to linux-pcmcia at lists.infradead.org
+
 typedef struct erase_info_t {
     u_long	Offset;
     u_long	Size;