[PATCH 3/3] mark unused/obsolete code in cs.c
Dominik Brodowski
linux at dominikbrodowski.de
Thu Mar 25 13:25:05 GMT 2004
A few functions in cs.c are unused. Mark them PCMCIA_OBSOLETE, and move the
corresponding EXPORT_SYMBOL calls closer to the functions.
drivers/pcmcia/cs.c | 22 ++++++++++++++++++----
include/pcmcia/cs.h | 13 ++++++++-----
2 files changed, 26 insertions(+), 9 deletions(-)
diff -ruN linux-original/drivers/pcmcia/cs.c linux/drivers/pcmcia/cs.c
--- linux-original/drivers/pcmcia/cs.c 2004-03-25 13:12:47.457343944 +0100
+++ linux/drivers/pcmcia/cs.c 2004-03-25 13:19:34.910401664 +0100
@@ -1032,6 +1032,8 @@
return CS_SUCCESS;
} /* get_card_services_info */
+#ifdef CONFIG_PCMCIA_OBSOLETE
+
/*======================================================================
Note that get_first_client() *does* recognize the Socket field
@@ -1055,6 +1057,7 @@
*handle = socket->clients;
return CS_SUCCESS;
} /* get_first_client */
+EXPORT_SYMBOL(pcmcia_get_first_client);
/*====================================================================*/
@@ -1074,10 +1077,15 @@
*handle = (*handle)->next;
return CS_SUCCESS;
} /* get_next_client */
+EXPORT_SYMBOL(pcmcia_get_next_client);
+
/*====================================================================*/
int pcmcia_get_window(window_handle_t *handle, int idx, win_req_t *req)
+#else /* CONFIG_PCMCIA_OBSOLETE */
+static int pcmcia_get_window(window_handle_t *handle, int idx, win_req_t *req)
+#endif /* CONFIG_PCMCIA_OBSOLETE */
{
struct pcmcia_socket *s;
window_t *win;
@@ -1296,6 +1304,8 @@
return CS_SUCCESS;
} /* modify_configuration */
+#ifdef CONFIG_PCMCIA_OBSOLETE
+
/*======================================================================
Modify the attributes of a window returned by RequestWindow.
@@ -1321,6 +1331,9 @@
return CS_SUCCESS;
} /* modify_window */
+EXPORT_SYMBOL(pcmcia_modify_window);
+
+#endif /* CONFIG_PCMCIA_OBSOLETE */
/*======================================================================
@@ -2058,6 +2071,8 @@
return ret;
} /* insert_card */
+#ifdef CONFIG_PCMCIA_OBSOLETE
+
/*======================================================================
Maybe this should send a CS_EVENT_CARD_INSERTION event if we
@@ -2082,6 +2097,9 @@
}
return CS_SUCCESS;
} /* set_event_mask */
+EXPORT_SYMBOL(pcmcia_set_event_mask);
+
+#endif /* CONFIG_PCMCIA_OBSOLETE */
/*======================================================================
@@ -2093,11 +2111,9 @@
EXPORT_SYMBOL(pcmcia_adjust_resource_info);
EXPORT_SYMBOL(pcmcia_deregister_client);
EXPORT_SYMBOL(pcmcia_eject_card);
-EXPORT_SYMBOL(pcmcia_get_first_client);
EXPORT_SYMBOL(pcmcia_get_card_services_info);
EXPORT_SYMBOL(pcmcia_get_configuration_info);
EXPORT_SYMBOL(pcmcia_get_mem_page);
-EXPORT_SYMBOL(pcmcia_get_next_client);
EXPORT_SYMBOL(pcmcia_get_first_region);
EXPORT_SYMBOL(pcmcia_get_first_tuple);
EXPORT_SYMBOL(pcmcia_get_first_window);
@@ -2109,7 +2125,6 @@
EXPORT_SYMBOL(pcmcia_insert_card);
EXPORT_SYMBOL(pcmcia_map_mem_page);
EXPORT_SYMBOL(pcmcia_modify_configuration);
-EXPORT_SYMBOL(pcmcia_modify_window);
EXPORT_SYMBOL(pcmcia_parse_tuple);
EXPORT_SYMBOL(pcmcia_register_client);
EXPORT_SYMBOL(pcmcia_release_configuration);
@@ -2123,7 +2138,6 @@
EXPORT_SYMBOL(pcmcia_request_window);
EXPORT_SYMBOL(pcmcia_reset_card);
EXPORT_SYMBOL(pcmcia_resume_card);
-EXPORT_SYMBOL(pcmcia_set_event_mask);
EXPORT_SYMBOL(pcmcia_suspend_card);
EXPORT_SYMBOL(pcmcia_validate_cis);
diff -ruN linux-original/include/pcmcia/cs.h linux/include/pcmcia/cs.h
--- linux-original/include/pcmcia/cs.h 2004-03-25 12:49:49.000000000 +0100
+++ linux/include/pcmcia/cs.h 2004-03-25 13:18:39.262861376 +0100
@@ -425,16 +425,12 @@
int pcmcia_deregister_client(client_handle_t handle);
int pcmcia_get_configuration_info(client_handle_t handle, config_info_t *config);
int pcmcia_get_card_services_info(servinfo_t *info);
-int pcmcia_get_first_client(client_handle_t *handle, client_req_t *req);
-int pcmcia_get_next_client(client_handle_t *handle, client_req_t *req);
-int pcmcia_get_window(window_handle_t *handle, int idx, win_req_t *req);
int pcmcia_get_first_window(window_handle_t *win, win_req_t *req);
int pcmcia_get_next_window(window_handle_t *win, win_req_t *req);
int pcmcia_get_status(client_handle_t handle, cs_status_t *status);
int pcmcia_get_mem_page(window_handle_t win, memreq_t *req);
int pcmcia_map_mem_page(window_handle_t win, memreq_t *req);
int pcmcia_modify_configuration(client_handle_t handle, modconf_t *mod);
-int pcmcia_modify_window(window_handle_t win, modwin_t *req);
int pcmcia_register_client(client_handle_t *handle, client_reg_t *req);
int pcmcia_release_configuration(client_handle_t handle);
int pcmcia_release_io(client_handle_t handle, io_req_t *req);
@@ -449,10 +445,17 @@
int pcmcia_resume_card(struct pcmcia_socket *skt);
int pcmcia_eject_card(struct pcmcia_socket *skt);
int pcmcia_insert_card(struct pcmcia_socket *skt);
-int pcmcia_set_event_mask(client_handle_t handle, eventmask_t *mask);
int pcmcia_report_error(client_handle_t handle, error_info_t *err);
struct pci_bus *pcmcia_lookup_bus(client_handle_t handle);
+#ifdef CONFIG_PCMCIA_OBSOLETE
+int pcmcia_get_first_client(client_handle_t *handle, client_req_t *req);
+int pcmcia_get_next_client(client_handle_t *handle, client_req_t *req);
+int pcmcia_get_window(window_handle_t *handle, int idx, win_req_t *req);
+int pcmcia_modify_window(window_handle_t win, modwin_t *req);
+int pcmcia_set_event_mask(client_handle_t handle, eventmask_t *mask);
+#endif
+
/* rsrc_mgr.c */
int pcmcia_adjust_resource_info(client_handle_t handle, adjust_t *adj);
More information about the linux-pcmcia
mailing list