2.6.x kernels & PCI-to-PCMCIA bridges [again]

[Russell King]

On Sat, Jun 19, 2004 at 01:14:07PM +0300, Jar wrote:
> But this code doesn't compile well. The Komuro's 31.5.2004 version
> compiles without errors/warnings.

No idea why you're getting these errors:

> [root at gw1 pd6729.final]# make
> Copying files: cirrus.h,i82365.h from /usr/src/linux/drivers/pcmcia/
> make -C /usr/src/linux SUBDIRS=/u1/src/pd6729.final/module modules \
> MODVERDIR=/u1/src/pd6729.final/module modules
> make[1]: Entering directory `/usr/src/linux-2.6.6-1.435'
>   LD      /u1/src/pd6729.final/module/built-in.o
>   CC [M]  /u1/src/pd6729.final/module/pd6729.o
> /u1/src/pd6729.final/module/pd6729.c: In function `indirect_read16':
> /u1/src/pd6729.final/module/pd6729.c:66: error: `reg' undeclared (first
> use in this function)

57:+static unsigned short indirect_read16(struct pd6729_socket *socket, unsigned short reg)
66:+       outb(reg, port);

'reg' is a function parameter, therefore it _is_ declared.  I suggest
that your mail client knows far more about white spacing rules than
the mail sender.

> /u1/src/pd6729.final/module/pd6729.c: In function `pd6729_get_socket':
> /u1/src/pd6729.final/module/pd6729.c:322: error: structure has no member
> named `dev'

This one is valid.

> /u1/src/pd6729.final/module/pd6729.c: At top level:
> /u1/src/pd6729.final/module/pd6729.c:611: warning: type defaults to `int'
> in declaration of `structpci_device_id'

In my patch, this reads:

+static int __devinit pd6729_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)

again, it's another effect if your mail client knowing too much about
white spacing (or rather, your mail client authors thinking that they
have the right to dictate how plain text should be formatted.)

> /u1/src/pd6729.final/module/pd6729.c:611: error: syntax error before '*'
> token
> /u1/src/pd6729.final/module/pd6729.c:612: warning: function declaration
> isn't a prototype
> /u1/src/pd6729.final/module/pd6729.c: In function `pd6729_pci_probe':
> /u1/src/pd6729.final/module/pd6729.c:633: error: `dev' undeclared (first
> use in this function)

and this is a side effect of the above error.

So, we've found one real problem and discovered that the mail client
you're using does stupid things with white spacing / long lines.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core