[PATCH 1/3] 2.6 PXA PCMCIA

[stefan.eletzhofer at eletztrick.de]

On Fri, Jan 30, 2004 at 12:14:59PM +0000, Russell King wrote:
> On Thu, Jan 29, 2004 at 03:53:12PM +0100, stefan.eletzhofer at eletztrick.de wrote:
> > The patch is basically a reworked version of nicos original PXA-PCMCIA
> > patch. It uses the same approach as the sa11x00 pcmcia drivers.
> 
> Since pxa2xx_core and sa11xx_core are so similar, could they be turned
> into some sort of library, rather than duplicating sa11xx_core

Yes, I see that, too. But I first wanted to get it working ;)

The only differences I found so far are the MCIO/ATT/XX/MEM speed settings,
which were done quite differently on the SA IIRC. Its used in the probe
function only, if I see it correctly. My later patches for PXA do include
platform-devices for doing the board-specific stuff. Maybe a second layer for
processor specific things, and a generic probe function?

The cpufreq notifiers would need to be done different, too.

How would this library be named? intelarm_core.c? I have no idea if other
ARM implementations use similar interfaces or not.

Have you had a look at patch #2 and #3, too? I fear they did not make it to
the pcmcia list somehow, despite I tried to send them twice, and thats why I
re-sent the whole bunch to the LAK. Sorry for cross-posting.

> 
> -- 
> Russell King
>  Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
>  maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
>                  2.6 Serial core

-- 
Eletztrick Computing - Customized Linux Development
Stefan Eletzhofer, Marktstrasse 43, DE-88214 Ravensburg
http://www.eletztrick.de