corresponding patches to [RFC]

[Dominik Brodowski]

On Sun, Jul 06, 2003 at 11:34:29PM +0100, Russell King wrote:
> On Thu, Jun 12, 2003 at 09:47:51PM +0200, Dominik Brodowski wrote:
> > Just a few changes to the RFC, the most important is that for static mapped
> > sockets its now enough to do "echo 1 > /sys/.../settings/start" [once all
> > other things are done properly, of course...]
> > 
> > 	Dominik
> > 
> > BTW: these changes are only released with the GPL v.2
> 
> Appologies for the delay in getting to this.

No problem, have been re-working these patches a bit in the past few days;
hopefully I'll get to publish a complete new patchset today.

> Can you clear the license change with David Hinds please?  I suspect that
> without David saying "ok" to it, and maybe asking for us to change the
> MAINTAINERS entry, Linus may not accept the patch.

To clarify some things: I don't care whether it's GPL v.2 or GPL/MPL.
However, some of the code I want to patch in is clearly based on differenct
GPL-only code. That's why I consider this step to be necessary. Nonetheless,
I'll ask David.

> > +	.ktype = &ktype_pcmcia_settings,
> 
> Hmm, this is adding attributes to the "pcmcia" bus, placing them in
> a directory called /sysfs/bus/pcmcia/settings ?

Aww, this seems to be a very old patchset you're reviewing here...

> I'm also slightly worried about the lifetime of the pcmcia_bus object.
> Although bus_unregister() makes it disappear from the sysfs tree, any
> references to that object and any sub-object will cause other code in
> the kernel to keep a reference to the pcmcia_bus_type, which gets
> really messy when the module whose storage it was using has long
> since gone.

Any module using pcmcia_bus will increase the refcount of ds.ko. Doesn't
this solve this problem?

	Dominik