two trivial PCMCIA patches [Was: three trivial PCMCIA patches]

Dominik Brodowski linux at
Sat Apr 19 09:46:25 BST 2003

On Fri, Apr 18, 2003 at 04:01:05AM -0400, Pavel Roskin wrote:
> pcnet.diff - Use SET_MODULE_OWNER instead of obsolete MOD_INC_USE_COUNT 
> and MOD_DEC_USE_COUNT.  Copying David Hinds as the maintainer.

Looks good.

> release_io.diff - Fix for a very nasty bug when I/O resources are not 
> freed for sockets with static memory but relocatable I/O windows.  
> alloc_io_space() skips allocation only if both SS_CAP_STATIC_MAP and 
> io_offset are set.  But release_io_space() only checks SS_CAP_STATIC_MAP.
> I think that SS_CAP_STATIC_MAP and io_offset should be independent -
> SS_CAP_STATIC_MAP for memory only, and io_offset for I/O only.  That's
> what the patch does.  There are no other references to io_offset, so this
> change of semantic (if SS_CAP_STATIC_MAP was meant to be checked) should
> be safe.

Sounds good, but I'll let Russell make this call.

Many thanks!


More information about the linux-pcmcia mailing list