[Linux-parport] [PATCH/RFC] parport_pc: remove ancient, overeager quirk that disables EPP support on many chipsets

Adam Baker linux at baker-net.org.uk
Thu Sep 15 16:23:06 EDT 2011

On Thursday 15 September 2011, Jonathan Nieder wrote:
> Hi,
> Greg KH wrote:
> > You can not add someone else's signed-off-by: line to a patch, please go
> > re-read Documentation/SubmittingPatches as to why.
> > 
> > And did Adam originally write this patch?  Or did you?  If Adam, please
> > set the authorship information properly.
> From a quick Google search:
> http://lists.infradead.org/pipermail/linux-parport/2008-March/000628.html
> It looks like this one does have Adam Baker's sign-off (and it is sad
> how long this patch seems to have sat without being submitted to
> mainline).

The code has sat around for a long time because when I first posted the patch 
I got no feedback to indicate if anyone else was suffering from the bug and if 
anyone else had hardware that exhibited the bug it was supposed to fix so I 
didn't want to pursue submitting it. Over the years I have seen occasional 
reports of users suffering from the problem but I no longer have any EPP 
hardware to test it on.

That's why I posted the mail that said if someone else can verify the patch is 
still useful I'm happy for it to be submitted with my signed off by on it (and 
the original mail did use an @ sign, the word at got added by an email 
obfuscator in a mailing list archive along the way.)

> I don't know who originally had the idea of removing that code.  See
> [1], [2], [3], and [4] for some early discussions.
> The current "intel parport bug" test this patch removes seems to have
> been introduced between 2.3.10pre5 and 2.3.10 (thanks to Dave Jones
> for the git tree that makes such searches easy!).  That means some
> time around June or July, 1999.  At the time, the parport maintainers
> according to MAINTAINERS were Phil Blundell, Tim Waugh, David
> Campbell, and Andrea Arcangeli.  From the patch "[PATCH] parport is an
> orphan", 2007-03-05, I infer that not all of them are still interested
> in the driver and whoever _is_ interested is probably subscribed to
> the (low-volume) linux-parport list.
> I'd say, why not get this patch in linux-next or -mm somehow and see
> if anyone screams?  It would be _very_ useful to find an actual
> instance of the "intel parport bug" so we could see what that code was
> supposed to do and do it better.
> Thanks,
> Jonathan
> [1] http://thread.gmane.org/gmane.linux.parport/322/focus=326
> [2] http://thread.gmane.org/gmane.linux.parport/324/focus=327
> [3] http://thread.gmane.org/gmane.linux.parport/806
> [4] http://thread.gmane.org/gmane.linux.parport/925/focus=929

More information about the Linux-parport mailing list