[Linux-parport] Re: AX88796 parallel port driver

[Andrew Morton]

Ben Dooks <ben-linux at fluff.org> wrote:
>
> +static void
> +parport_ax88796_enable_irq(struct parport *p)
> +{
> +	struct ax_drvdata *dd = pp_to_drv(p);
> +	unsigned long flags;
> +
> +	local_irq_save(flags);
> +	if (!dd->irq_enabled) {
> +		enable_irq(p->irq);
> +		dd->irq_enabled = 1;
> +	}
> +	local_irq_restore(flags);
> +}

What's the local_irq_save() doing in there?  On SMP it won't afford any
particular protection from anything.  Or it this a will-only-ever-run-on-UP
thing?