[Linux-parport] Re: [PATCHv2] parport: add parallel port support for SGI O2

Arnaud Giersch arnaud.giersch at free.fr
Tue Jan 24 18:33:16 EST 2006

Mardi 24 janvier 2006, vers 00:38:57 (+0100), j'ai écrit:

> I will correct the style.


> I will add a comment to explain it in the code.


> I did not realized that.  I will try to correct the problem.

An updated version is available at

Since all changes are non-functional ones, I did not want to flood the
lists again with the full patch.

Changes are:

  * Address comments from Andrew Morton <akpm_at_osdl.org>:
    - Style: avoid single line "if" and "case" statements.
    - Turn some printk() into pr_debug1(), so that they only exist
      in debugging mode.
    - Add a comment about "volatile".
    - Add a comment about readsb() and writesb().
  * Only define DEBUG_PARPORT_IP32 if it is not already defined.
  * Remove the CVS $Id$ line.


More information about the Linux-parport mailing list