[PATCH] nvme-cli: nvmf-autoconnect: Consolidate vendor-specific NVMe-oF udev rules into a single file

[Xose Vazquez Perez]

On 11/9/26 11:09 AM, Martin Wilck wrote:

> On Mon, 2026-11-09 at 01:08 +0100, Xose Vazquez Perez wrote:
>> Cc: John Garry <john.garry at linux.dev>
>> Cc: Nilay Shroff <nilay at linux.ibm.com>
>> Cc: Guixin Liu <kanie at linux.alibaba.com>
>> Cc: Wayne Berthiaume <Wayne.Berthiaume at dell.com>
>> Cc: Vasuki Manikarnike <vasuki.manikarnike at hpe.com>
>> Cc: Matthias Rudolph <Matthias.Rudolph at hitachivantara.com>
>> Cc: Martin George <marting at netapp.com>
>> Cc: NetApp RDAC team <ng-eseries-upstream-maintainers at netapp.com>
>> Cc: Zou Ming <zouming.zouming at huawei.com>
>> Cc: Li Xiaokeng <lixiaokeng at huawei.com>
>> Cc: Randy Jennings <randyj at purestorage.com>
>> Cc: Jyoti Rani <jrani at purestorage.com>
>> Cc: Brian Bunker <brian at purestorage.com>
>> Cc: Uday Shankar <ushankar at purestorage.com>
>> Cc: Chaitanya Kulkarni <kch at nvidia.com>
>> Cc: Sagi Grimberg <sagi at grimberg.me>
>> Cc: Keith Busch <kbusch at kernel.org>
>> Cc: Christoph Hellwig <hch at lst.de>
>> Cc: Marco Patalano <mpatalan at redhat.com>
>> Cc: Ewan D. Milne <emilne at redhat.com>
>> Cc: John Meneghini <jmeneghi at redhat.com>
>> Cc: Daniel Wagner <dwagner at suse.de>
>> Cc: Daniel Wagner <wagi at monom.org>
>> Cc: Hannes Reinecke <hare at suse.de>
>> Cc: Martin Wilck <mwilck at suse.com>
>> Cc: Benjamin Marzinski <bmarzins at redhat.com>
>> Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
>> Cc: BLOCK-ML <linux-block at vger.kernel.org>
>> Cc: NVME-ML <linux-nvme at lists.infradead.org>
>> Cc: SCSI-ML <linux-scsi at vger.kernel.org>
>> Cc: DM_DEVEL-ML <dm-devel at lists.linux.dev>
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>

> Generally a good idea, but I think nvme-cli has a GitHub based
> development workflow these days.

While GitHub is an option, web-based interfaces tend to limit patch
visibility and broad review reach across subsystems. Mailing lists
remain far more versatile for cross-project visibility and discussion.

> I'm not a fan of repeated lengthy match expressions in udev rules.
> Can we improve the readability by using GOTOs and LABELS?

Using GOTOs and LABELS cleans up the duplicated model match expressions nicely.
However, the scope of this patch is intentionally kept to a pure consolidation.