[PATCH v2 0/9] nvme: dead code cleanups

[Keith Busch]

On Fri, 6 Nov 2026 10:27:27 +0800, Guixin Liu wrote:
> A round of dead code removals in the nvme host and target drivers,
> all found by code inspection. Every patch stands on its own and can
> be picked individually:
> 
>  - the NVMEQ_DELETE_ERROR flag lost its only reader in 2020 and is
>    now write-only; dropping it also removes the nvme_del_cq_end()
>    wrapper, which degenerates to nvme_del_queue_end() without it
>  - struct fields never referenced since they were introduced:
>    nvme_fc_queue.seqno, nvme_dhchap_queue_context.entry,
>    nvmet_fc_ls_iod.fcpreq and nvmet_fc_tgt_queue.ninetypercent
>  - a hostnqn already-assigned check that can never fire because
>    opts->host is only set after the option parsing loop
>  - the reconnect_delay "off" case, copied from fast_io_fail_tmo but
>    unreachable for an unsigned value the parser bounds to positive
>    values, along with its sentence in the ABI documentation
>  - an address family map entry that both show and store skip, an
>    unreachable break in the passthru feature handling, and a drain
>    of an SQ list that is never populated
> 
> [...]

Thanks, applied to nvme-7.4.

[1/9] nvme-pci: remove write-only NVMEQ_DELETE_ERROR flag
      commit: 51a08d499c3a2e69ff2509a8c67249b51a52f0c2
[2/9] nvme-fc: remove dead seqno field in nvme_fc_queue
      commit: 21e384dfa497f5bdb987e104652e3a11cda80e75
[3/9] nvme-auth: remove dead entry field in nvme_dhchap_queue_context
      commit: 6e31e030e2004b94f663f7a8bef54e4db79d6db6
[4/9] nvme-fabrics: remove dead hostnqn already-assigned check
      commit: c621d47b7a454a105e7b873d61cd69dcf84d0451
[5/9] nvme: drop unreachable "off" case in reconnect_delay_show()
      commit: 9762c7ae1ee709f6dc3823d151391f89457b5492
[6/9] nvmet-fc: remove dead fields in nvmet_fc_ls_iod and nvmet_fc_tgt_queue
      commit: f7a3f5f72b8b8c53972a6848290e8121e786b4c4
[7/9] nvmet: remove unreachable "pcie" entry from the address family map
      commit: 16fc085d86144c7f6e1c9b70e9d9fe562f8d611e
[8/9] nvmet: passthru: remove unreachable break statements
      commit: 2b7982b06cc877584942d82d071a28a2a9e83603
[9/9] nvmet-pci-epf: don't drain the never-populated SQ list
      commit: 66e3ef5dad6d22a79cb32b614d2a37a166a5437b
--
Keith Busch <kbusch at kernel.org>