[PATCH v2 4/9] nvme-fabrics: remove dead hostnqn already-assigned check

Nilay Shroff nilay at linux.ibm.com
Fri Nov 6 05:17:05 PST 2026


On 11/6/26 7:57 AM, Guixin Liu wrote:
> The opts->host check in the NVMF_OPT_HOSTNQN handler can never fire:
> options are parsed into a freshly allocated struct, and opts->host is
> only assigned after the parsing loop completes. A duplicate hostnqn
> option is already silently overridden by the strscpy() into the local
> buffer. Remove the dead check.
> 
> Signed-off-by: Guixin Liu<kanie at linux.alibaba.com>

Looks good to me:
Reviewed-by: Nilay Shroff <nilay at linux.ibm.com>




More information about the Linux-nvme mailing list