[PATCH v2 1/9] nvme-pci: remove write-only NVMEQ_DELETE_ERROR flag

Nilay Shroff nilay at linux.ibm.com
Fri Nov 6 05:12:45 PST 2026


On 11/6/26 7:57 AM, Guixin Liu wrote:
> Commit fa46c6fb5d61b ("nvme/pci: move cqe check after device shutdown")
> removed the only reader of the NVMEQ_DELETE_ERROR flag, but left the
> flag and its two writes behind. Without a reader the flag carries no
> state, and nvme_del_cq_end() degenerates to a plain wrapper around
> nvme_del_queue_end(), which the SQ deletion path already uses directly.
> 
> Remove the flag, its writes, and the now redundant wrapper.
> 
> Signed-off-by: Guixin Liu<kanie at linux.alibaba.com>

Looks good to me:
Reviewed-by: Nilay Shroff <nilay at linux.ibm.com>



More information about the Linux-nvme mailing list