Re: [PATCH 1/2] nvmet: zero out unused data of fixed-size log pages
shao.mingyin at zte.com.cn
shao.mingyin at zte.com.cn
Fri Nov 6 02:54:37 PST 2026
On Fri, Nov 06, 2026 at 11:39:32AM +0100, Christoph Hellwig wrote:
> Given none of these are in a fast path, should we simply zero the
> entire transfer length first?
Yes. v2 does that: each handler zeroes the whole transfer length and
then copies the fixed structure over it, instead of zeroing the unused
tail afterwards. The Error log zeroes first as well and clamps the ring
walk to the requested length.
> Also please cut down the commit messages a bit to be on-point.
I also cut both commit messages down; the long rationale is gone.
v2 follows.
Thanks,
Shao
More information about the Linux-nvme
mailing list