[PATCH v2 0/9] nvme: dead code cleanups
Guixin Liu
kanie at linux.alibaba.com
Thu Nov 5 18:27:27 PST 2026
A round of dead code removals in the nvme host and target drivers,
all found by code inspection. Every patch stands on its own and can
be picked individually:
- the NVMEQ_DELETE_ERROR flag lost its only reader in 2020 and is
now write-only; dropping it also removes the nvme_del_cq_end()
wrapper, which degenerates to nvme_del_queue_end() without it
- struct fields never referenced since they were introduced:
nvme_fc_queue.seqno, nvme_dhchap_queue_context.entry,
nvmet_fc_ls_iod.fcpreq and nvmet_fc_tgt_queue.ninetypercent
- a hostnqn already-assigned check that can never fire because
opts->host is only set after the option parsing loop
- the reconnect_delay "off" case, copied from fast_io_fail_tmo but
unreachable for an unsigned value the parser bounds to positive
values, along with its sentence in the ABI documentation
- an address family map entry that both show and store skip, an
unreachable break in the passthru feature handling, and a drain
of an SQ list that is never populated
Compile tested only.
Changes since v1:
- fold the Documentation/ABI/stable/sysfs-nvme update into patch 5,
whose show function no longer returns "off" (reported by Sashiko)
Link: https://lore.kernel.org/all/20261105021051.1667222-1-kanie@linux.alibaba.com/
Guixin Liu (9):
nvme-pci: remove write-only NVMEQ_DELETE_ERROR flag
nvme-fc: remove dead seqno field in nvme_fc_queue
nvme-auth: remove dead entry field in nvme_dhchap_queue_context
nvme-fabrics: remove dead hostnqn already-assigned check
nvme: drop unreachable "off" case in reconnect_delay_show()
nvmet-fc: remove dead fields in nvmet_fc_ls_iod and nvmet_fc_tgt_queue
nvmet: remove unreachable "pcie" entry from the address family map
nvmet: passthru: remove unreachable break statements
nvmet-pci-epf: don't drain the never-populated SQ list
Documentation/ABI/stable/sysfs-nvme | 3 +--
drivers/nvme/host/auth.c | 1 -
drivers/nvme/host/fabrics.c | 6 ------
drivers/nvme/host/fc.c | 1 -
drivers/nvme/host/pci.c | 20 +-------------------
drivers/nvme/host/sysfs.c | 2 --
drivers/nvme/target/configfs.c | 5 ++---
drivers/nvme/target/fc.c | 3 ---
drivers/nvme/target/passthru.c | 2 --
drivers/nvme/target/pci-epf.c | 2 --
10 files changed, 4 insertions(+), 41 deletions(-)
--
2.43.7
More information about the Linux-nvme
mailing list