[PATCH 07/19] nvmet-tcp: let the accept work come to an end
Christoph Hellwig
hch at lst.de
Mon Nov 2 22:02:49 PST 2026
On Thu, Oct 29, 2026 at 08:52:40AM -0700, Keith Busch wrote:
> From: Josef Bacik <josef at toxicpanda.com>
>
> nvmet_tcp_accept_work() loops until there's nothing left to accept, and
> anyone opening and closing connections fast enough keeps it running
> indefinitely, since tearing down a dead connection takes long enough for
> more to arrive. Whoever flushes nvmet_wq waits for it: removing any
> other port of the target does in nvmet_port_release(), and so does
> unloading the rdma and fc modules.
>
> Accept a bounded number of connections per run and requeue the work. A
> flush doesn't wait for work queued behind it.
The subject is very odd, and should probably use something more like
a shortened version of this sentence.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch at lst.de>
More information about the Linux-nvme
mailing list