[PATCH] fabrics: fix NULL dereference in nvmf_update_tls_concat
Stuart Hayes
stuart.w.hayes at gmail.com
Wed May 6 13:53:45 PDT 2026
The recently added function nvmf_update_tls_concat() dereferences struct
nvmf_disc_log_entry *e, but e will always be NULL when called via
libnvmf_discovery_nbft(). This can result in a segmentation fault when
attempting "nvme connect-all --nbft".
Check for NULL pointer before dereferencing.
Signed-off-by: Stuart Hayes <stuart.w.hayes at gmail.com>
---
libnvme/src/nvme/fabrics.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libnvme/src/nvme/fabrics.c b/libnvme/src/nvme/fabrics.c
index 4572b9c5b..326287ec6 100644
--- a/libnvme/src/nvme/fabrics.c
+++ b/libnvme/src/nvme/fabrics.c
@@ -1228,6 +1228,9 @@ __public int libnvmf_disconnect_ctrl(libnvme_ctrl_t c)
static void nvmf_update_tls_concat(struct nvmf_disc_log_entry *e,
libnvme_ctrl_t c, libnvme_host_t h)
{
+ if (!e)
+ return;
+
if (e->trtype != NVMF_TRTYPE_TCP ||
e->tsas.tcp.sectype == NVMF_TCP_SECTYPE_NONE)
return;
--
2.51.0
More information about the Linux-nvme
mailing list