[PATCH 7/8] fs/configfs: switch to get_tree_keyed()

[Hannes Reinecke]

On 6/17/26 13:51, Christian Brauner wrote:
> On Sat, Jun 13, 2026 at 01:14:36PM +0200, Hannes Reinecke wrote:
>> Switch to get_tree_keyed() to instatiate a new superblock whenever
>> the mount namespace changed.
>>
>> Signed-off-by: Hannes Reinecke <hare at kernel.org>
>> ---
> 
> So I wonder what keying superblock creation to the mount namespace
> really gets you. Imho keying the superblock by namespace only makes
> sense if the whole filesystem is tied to a namespace. For example, the
> mqueue filesystem is semantically tied to ipc namespaces so tying the
> creation of a new mqueue superblock to the ipc namespace makes sense.
> 
> But configs isn't semantically tied to the mount namespace at all. It
> encompasses a bunch of different subsystems that might themselves be
> semantically tied to different namespaces. The specific example you care
> about is nvme tied to network namespaces. But there might be other
> things that tie to other namespaces.
> 
> So even if you tie it to the mount namespace you presumably still need
> to filter what subsystems a specific configfs instance will display to
> each accessing task based on the namespaces of the accessing task?

Actually, I'm only interested in the namespace ID, as I'm using that
to lookup the corresponding 'configfs_super_info' structure from the
xarray.
I _thought_ keying it off the mount namespace might be the 'done' thing,
as otherwise I might presume future use-cases. But turns out that
the mount namespace is pretty much an internal thing, and really
unwieldy to use.
So I can easily switch over to the net namespace, and let other users
to fix thing up if it doesn't work for them.

Okay, I'll switch over to the network namespace here.
That certainly keeps sashiko happy if nothing else :-)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich