[PATCH] nvme: make some sysfs diagnostic structures static

John Garry john.g.garry at oracle.com
Wed Jun 10 02:28:44 PDT 2026


>>   }
>> -struct device_attribute dev_attr_adm_errors =
>> +static struct device_attribute dev_attr_adm_errors =
>>       __ATTR(command_error_count, 0644,
>>           nvme_adm_errors_show, nvme_adm_errors_store);
> BTW, kernel test robot also reported this same issue here:
> https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild- 
> all/202606101329.T3zXNqdy-lkp at intel.com/__;!!ACWV5N9M2RV99hQ! 
> P5UdkxQBbB6XuNloxfIJKNALsPKk8vSXQENG4khm- 
> SufSw1QG_Ndga5ZvcKhtCypHWJDcNkaE1KDvZZ8pO8$
> So you may want to add closes tag pointing to the above link. Otherwise,
> this change looks good to me.
> 

I would not have noticed that, but here is the necessary tag anyway:

Closes: 
https://lore.kernel.org/oe-kbuild-all/202606101329.T3zXNqdy-lkp@intel.com/

> Reviewed-by: Nilay Shroff <nilay at linux.ibm.com>

Cheers




More information about the Linux-nvme mailing list