[RFC PATCH v1 00/17] blk-cgroup: protect blkgs with blkcg_mutex
yu kuai
yukuai at fygo.io
Thu Jul 9 03:08:36 PDT 2026
Hi,
在 2026/7/9 14:09, Christoph Hellwig 写道:
> On Sun, Jul 05, 2026 at 03:51:07AM +0800, Yu Kuai wrote:
>> From: Yu Kuai <yukuai at fygo.io>
>>
>> This RFC moves queue-local blkg topology synchronization from
>> q->queue_lock to q->blkcg_mutex.
>>
>> q->queue_lock is a hot block-layer spinlock used by request queue runtime
>> paths,
> I don't think it is hot any more. If it is in one of your workloads
> we have a deep problem somewhere. That being said, futher removing
> uses of his old catch-all lock is always good, hopefully we can
> eventually remove it entirely.
>
> So this series looks great to me conceptually, but I'm unfortunately
> not a very qualified reviewer for the blk-cgroup code.
Thanks a lot for taking a look at this RFC set, it's very helpful.
It's true that blk-cgroup review is not active for a long time. I'd like to
help but I really don't have time to check every block layer patches.
>
--
Thanks,
Kuai
More information about the Linux-nvme
mailing list