[PATCH rdma-next v8] RDMA: Change capability fields in ib_device_attr from int to u32
Erni Sri Satya Vennela
ernis at linux.microsoft.com
Wed Jul 1 23:03:43 PDT 2026
On Fri, Jun 19, 2026 at 01:30:39PM -0700, Erni Sri Satya Vennela wrote:
> The capability counter fields in struct ib_device_attr are declared
> as signed int, but these values are inherently non-negative. Drivers
> maintain their cached caps as u32 and assign them directly into these
> int fields; if a cap exceeds INT_MAX the implicit narrowing yields a
> negative value visible to the IB core.
>
> Change the signed int capability fields to u32 to match the
> underlying nature of the data. Also update consumers across the IB
> core, ULPs, NVMe-oF target, RDS, and NFS/RDMA so the new u32 values
> are not forced back through signed int or u8 via min()/min_t() or
> narrowing local variables.
>
> Suggested-by: Jason Gunthorpe <jgg at nvidia.com>
> Signed-off-by: Erni Sri Satya Vennela <ernis at linux.microsoft.com>
> Acked-by: Stefan Metzmacher <metze at samba.org> # smbdirect
Hi,
Just a friendly follow-up on this patch. The Sashiko review mentioned a
low-priority item, and I'd appreciate any guidance on whether the change
is needed.
https://sashiko.dev/#/patchset/20260619203107.606359-1-ernis%40linux.microsoft.com
Thanks,
Vennela
More information about the Linux-nvme
mailing list