[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Keith Busch
kbusch at kernel.org
Mon Feb 2 22:14:23 PST 2026
On Tue, Feb 03, 2026 at 06:27:56AM +0100, Christoph Hellwig wrote:
> > iod->nr_descriptors = 0;
> > iod->total_len = 0;
> > iod->meta_total_len = 0;
> > + iod->nr_dma_vecs = 0;
> > + iod->dma_vecs = NULL;
>
> I don't think we need the dma_vecs initialization here, as everything
> is keyed off nr_dma_vecs.
Yes, we should definitely use nr_dma_vecs and skip the NULL setting. I'm
a big fan removing unnecessary initialisations. Just a caution, my
suggested patch has this check:
if (!iod->dma_vecs)
So we just need to update it to use 'iod->nr_dma_vecs' instead, which
would have been correct, too.
More information about the Linux-nvme
mailing list