[PATCH 1/7] nvme: export command retry count via sysfs

Nilay Shroff nilay at linux.ibm.com
Mon Feb 2 05:33:33 PST 2026



On 1/31/26 2:03 AM, Keith Busch wrote:
> On Fri, Jan 30, 2026 at 11:50:18PM +0530, Nilay Shroff wrote:
>>  	nvme_req(req)->retries++;
>> +	if (ns)
>> +		ns->retries++;
>> +	else
>> +		nvme_req(req)->ctrl->retries++;
> 
> I don't think admin commands ever retry with this driver, so probably
> not worth tracking it.
Yeah got it. I will drop retry counter for admin commands.
> 
> And as unlikely as it is to happen, might want to ensure it doesn't
> wrap back to zero. The size_add() function handles that.
Sure, makes sense. 

I will fix these in next patch revision.

Thanks,
--Nilay



More information about the Linux-nvme mailing list