[PATCH 7/6 RFC] nvme: test per-command retry delay

[Sagi Grimberg]

On 30/08/2026 11:23, Shin'ichiro Kawasaki wrote:
> On Aug 23, 2026 / 11:49, Sagi Grimberg wrote:
>> Add tests to exercise host command retry delays handling.
>>
>> 070: check that basic command RETRY disposition works and respect ctrl
>>       crd
>> 071: check that basic command FAILOVER disposition works and respects
>>       ctrl crd
>> 072: check that different commands completed with different crd levels
>>       are retried independently, each respecting its paired completion
>>       crd level
>> 073: check that different commands completed with different crd levels
>>       are failed-over independently, each respecting its paired completion
>>       crd level
>>
>> These tests rely on nvmet support for subsystem crdt attributes
>> (_require_nvmet_crdt) and nvme host crd error injection support.
>>
>> In addition we add some common nvme helpers to set nvmet attributes,
>> inject errors, and leverage nvme diags to count retries/failovers.
>>
>> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> Thank you for the patch. I ran the added four test cases using the kernel with
> the kernel patches, and observed the all four test cases passed. Good.
>
> I walked through the new test cases. Overall, they look good. One point to
> improve is the global variable used to return a value. I will comment it in-
> line.
>
> I found the new test cases measure some numbers like retry count, failover
> count, or elapsed times. Those numbers are used as pass/fail criteria. The
> numbers are logged in the FULL file, but it might be useful to print the
> numbers in the test run console like this:

Thanks - will wait for some more feedback before a respin.