[PATCH v5 11/16] nvme-pci: add SGL support for the dmabuf path
Pavel Begunkov
asml.silence at gmail.com
Sat Aug 1 08:46:23 PDT 2026
From: Anuj Gupta <anuj20.g at samsung.com>
Add SGL support in addition to PRP for dmabuf-backed requests,
building the descriptor list from the mapping's sg_table.
Signed-off-by: Anuj Gupta <anuj20.g at samsung.com>
Signed-off-by: Pavel Begunkov <asml.silence at gmail.com>
---
drivers/nvme/host/pci.c | 153 ++++++++++++++++++++++++++++++++++++++--
1 file changed, 149 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 7b8ed101a13b..67e26d6e8f25 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1287,12 +1287,18 @@ static blk_status_t nvme_pci_setup_data_prp(struct request *req,
return BLK_STS_IOERR;
}
+static void nvme_pci_sgl_set_data(struct nvme_sgl_desc *sge,
+ dma_addr_t addr, u32 len)
+{
+ sge->addr = cpu_to_le64(addr);
+ sge->length = cpu_to_le32(len);
+ sge->type = NVME_SGL_FMT_DATA_DESC << 4;
+}
+
static void nvme_pci_dma_iter_set_sgl(struct nvme_sgl_desc *sge,
struct blk_dma_iter *iter)
{
- sge->addr = cpu_to_le64(iter->addr);
- sge->length = cpu_to_le32(iter->len);
- sge->type = NVME_SGL_FMT_DATA_DESC << 4;
+ nvme_pci_sgl_set_data(sge, iter->addr, iter->len);
}
static void nvme_pci_sgl_set_seg(struct nvme_sgl_desc *sge,
@@ -1303,6 +1309,145 @@ static void nvme_pci_sgl_set_seg(struct nvme_sgl_desc *sge,
sge->type = NVME_SGL_FMT_LAST_SEG_DESC << 4;
}
+static unsigned int nvme_pci_dmabuf_sgl_nents(struct request *req)
+{
+ struct bio *bio = req->bio;
+ struct nvme_dmabuf_map *map = to_nvme_dmabuf_map(bio->bi_dmabuf_map);
+ struct scatterlist *sg;
+ unsigned long tmp;
+ size_t offset = bio->bi_iter.bi_offset;
+ size_t remaining = blk_rq_payload_bytes(req);
+ unsigned int nents = 0;
+
+ for_each_sgtable_dma_sg(map->sgt, sg, tmp) {
+ size_t sg_len = sg_dma_len(sg);
+
+ if (!remaining)
+ break;
+ if (offset >= sg_len) {
+ offset -= sg_len;
+ continue;
+ }
+
+ sg_len -= offset;
+ offset = 0;
+
+ do {
+ size_t chunk = min(remaining, sg_len);
+
+ nents++;
+ sg_len -= chunk;
+ remaining -= chunk;
+ } while (sg_len && remaining);
+ }
+
+ if (unlikely(remaining))
+ return 0;
+
+ return nents;
+}
+
+static blk_status_t nvme_rq_setup_dmabuf_sgl(struct request *req,
+ struct nvme_queue *nvmeq, unsigned int entries)
+{
+ struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
+ struct bio *bio = req->bio;
+ struct nvme_dmabuf_map *map = to_nvme_dmabuf_map(bio->bi_dmabuf_map);
+ size_t length = blk_rq_payload_bytes(req);
+ struct nvme_sgl_desc *sg_list = &iod->cmd.common.dptr.sgl;
+ bool pooled = entries > 1;
+ dma_addr_t sgl_dma = 0;
+ unsigned int mapped = 0;
+ unsigned long tmp;
+ struct scatterlist *sg;
+ size_t offset = bio->bi_iter.bi_offset;
+ size_t remaining = length;
+
+ if (!entries)
+ return BLK_STS_IOERR;
+
+ iod->cmd.common.flags = NVME_CMD_SGL_METABUF;
+ iod->total_len = length;
+
+ nvme_dmabuf_map_sync_for_device(nvmeq->dev, req);
+
+ /* entries == 1 fits in the inline descriptor; more needs a pool. */
+ if (pooled) {
+ if (entries <= NVME_SMALL_POOL_SIZE / sizeof(*sg_list))
+ iod->flags |= IOD_SMALL_DESCRIPTOR;
+
+ sg_list = dma_pool_alloc(nvme_dma_pool(nvmeq, iod), GFP_ATOMIC,
+ &sgl_dma);
+ if (!sg_list)
+ return BLK_STS_RESOURCE;
+ iod->descriptors[iod->nr_descriptors++] = sg_list;
+ }
+
+ for_each_sgtable_dma_sg(map->sgt, sg, tmp) {
+ size_t sg_len = sg_dma_len(sg);
+ dma_addr_t addr = sg_dma_address(sg);
+
+ if (!remaining)
+ break;
+ if (offset >= sg_len) {
+ offset -= sg_len;
+ continue;
+ }
+
+ addr += offset;
+ sg_len -= offset;
+ offset = 0;
+
+ do {
+ u32 chunk = min_t(size_t, remaining, sg_len);
+
+ if (WARN_ON_ONCE(mapped == entries))
+ goto err_free;
+ nvme_pci_sgl_set_data(&sg_list[mapped++], addr, chunk);
+
+ addr += chunk;
+ sg_len -= chunk;
+ remaining -= chunk;
+ } while (sg_len && remaining);
+ }
+
+ if (unlikely(remaining))
+ goto err_free;
+
+ if (pooled)
+ nvme_pci_sgl_set_seg(&iod->cmd.common.dptr.sgl, sgl_dma,
+ mapped);
+ return BLK_STS_OK;
+err_free:
+ if (pooled) {
+ iod->nr_descriptors--;
+ dma_pool_free(nvme_dma_pool(nvmeq, iod), sg_list, sgl_dma);
+ }
+ return BLK_STS_IOERR;
+}
+
+static blk_status_t nvme_rq_setup_dmabuf(struct request *req,
+ struct nvme_queue *nvmeq, enum nvme_use_sgl use_sgl)
+{
+ unsigned int entries;
+ size_t avg_seg;
+
+ if (use_sgl == SGL_UNSUPPORTED)
+ return nvme_rq_setup_dmabuf_map(req, nvmeq);
+
+ entries = nvme_pci_dmabuf_sgl_nents(req);
+
+ if (use_sgl == SGL_FORCED)
+ return nvme_rq_setup_dmabuf_sgl(req, nvmeq, entries);
+
+ avg_seg = entries ?
+ DIV_ROUND_UP(blk_rq_payload_bytes(req), entries) : 0;
+ if (sgl_threshold && avg_seg >= sgl_threshold)
+ return nvme_rq_setup_dmabuf_sgl(req, nvmeq, entries);
+
+ return nvme_rq_setup_dmabuf_map(req, nvmeq);
+}
+
static blk_status_t nvme_pci_setup_data_sgl(struct request *req,
struct blk_dma_iter *iter)
{
@@ -1398,7 +1543,7 @@ static blk_status_t nvme_map_data(struct request *req)
blk_status_t ret;
if (blk_mq_rq_is_dmabuf(req))
- return nvme_rq_setup_dmabuf_map(req, nvmeq);
+ return nvme_rq_setup_dmabuf(req, nvmeq, use_sgl);
/*
* Try to skip the DMA iterator for single segment requests, as that
--
2.54.0
More information about the Linux-nvme
mailing list