[PATCH v3 2/2] nvme: initialize known effects to set ns_mgmt NCC and ns_attach NIC

Keith Busch kbusch at kernel.org
Mon Apr 27 23:51:39 PDT 2026


On Sat, Apr 25, 2026 at 10:04:13PM +0900, Tokunori Ikegami wrote:
> This is to make sure scan_work done for the commands.
> Since nvme_passthru_end called when effects set.
> Also scan_work is flushed when NIC or NCC effects set.
> 
> The change is to improvement the scan_work to make sure.
> Always do scan for the ns_mgmt and ns_attach commands.
> All drives supporting ns_mgmt and ns_attach should have the entries.
> But no need to be depended on it as always do scan.

I suppose that's why the "known_effects" exists, but it'd be
dissappointing if we really need this. The other opcodes in there
existed before the Command Effects Log was created, so understandable
that controllers may not implement it. But NS management/attach were
introduced after the log, and there is also the AEN that the driver
could rescan on receipt, so it's doubly bad if a controller
implementation really needs this.



More information about the Linux-nvme mailing list