[PATCH V3 4/8] nvme: add sysfs attribute to change IO timeout per nvme controller

[Daniel Wagner]

On Mon, Apr 27, 2026 at 11:13:43AM +0200, Maurizio Lombardi wrote:
> >> @@ -5136,6 +5137,7 @@ int nvme_init_ctrl(struct nvme_ctrl *ctrl, struct device *dev,
> >>  	ctrl->ka_cmd.common.opcode = nvme_admin_keep_alive;
> >>  	ctrl->ka_last_check_time = jiffies;
> >>  	ctrl->admin_timeout = NVME_ADMIN_TIMEOUT;
> >> +	ctrl->io_timeout = NVME_IO_TIMEOUT;
> >
> > Should this be initialized with the defaults from the module load time?
> 
> 
> Yes, note that NVME_IO_TIMEOUT is a macro that depends on the
> "nvme_io_timeout" module parameter set at load time.

Ah yes, didn't read the definition of NVME_IO_TIMEOUT. Sorry for the
noise.

The rest looks good to me.

Reviewed-by: Daniel Wagner <dwagner at suse.de>