[PATCH V3 2/8] nvme: add sysfs attribute to change admin timeout per nvme controller

Daniel Wagner dwagner at suse.de
Thu Apr 23 10:04:17 PDT 2026


On Thu, Apr 23, 2026 at 02:58:25PM +0200, Maurizio Lombardi wrote:
> >> if the NVME_CTRL_STARTED_ONCE bit is set, we know that the
> >> initialization has been completed and that admin_q and fabrics_q will
> >> exist until the controller will be torn down.
> >
> > Yes, that is all fine but I think it would be good to be able to use
> > udev here as we have it other timeouts.
> 
> Ok I understand, what do you think if we swap the order in
> nvme_start_ctrl() so the flag is set before userspace is notified?
> 
> set_bit(NVME_CTRL_STARTED_ONCE, &ctrl->flags);
> nvme_change_uevent(ctrl, "NVME_EVENT=connected");

I doesn't look like there is anything else depending on this order. So
yes, that would make this race go away.



More information about the Linux-nvme mailing list