[PATCH] nvme-cli: attach ns to local controller if none specified

Chaitanya Kulkarni chaitanyak at nvidia.com
Mon Mar 31 13:37:31 PDT 2025


On 3/31/25 12:08, Keith Busch wrote:
> From: Keith Busch<kbusch at kernel.org>
>
> Assume the user meant to attach the namespace to the controller the
> command was sent to if the user didn't provide a controller id list.
>
> Suggested-by: Nilay Shroff<nilay at linux.ibm.com>
> Signed-off-by: Keith Busch<kbusch at kernel.org>

this will not be backward compatible hence all the existing deployments
that are resulting in error [1] will now attach the default controller,
I believe that is what is expected ?

if not then do we need add a version check so it will stay as backward
compatible ?

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>

-ck

[1]
-		fprintf(stderr, "warning: empty controller-id list will result in no actual change in namespace attachment\n");



More information about the Linux-nvme mailing list