[PATCH v2 15/15] nvmet-fc: put ref when assoc->del_work is already scheduled

Daniel Wagner wagi at kernel.org
Tue Mar 11 03:11:41 PDT 2025


Do not leak the tgtport reference when the work is already scheduled.

Signed-off-by: Daniel Wagner <wagi at kernel.org>
---
 drivers/nvme/target/fc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index 50cfa02bf8cd1bc39ee8ca3f0b260c5a8733a9df..a948e0856502686294e42826669fd9bd71121c62 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -1089,7 +1089,8 @@ static void
 nvmet_fc_schedule_delete_assoc(struct nvmet_fc_tgt_assoc *assoc)
 {
 	nvmet_fc_tgtport_get(assoc->tgtport);
-	queue_work(nvmet_wq, &assoc->del_work);
+	if (!queue_work(nvmet_wq, &assoc->del_work))
+		nvmet_fc_tgtport_put(assoc->tgtport);
 }
 
 static bool

-- 
2.48.1




More information about the Linux-nvme mailing list