[PATCH] nvme: simplify request ready check for pci
Keith Busch
kbusch at kernel.org
Mon Mar 10 08:01:55 PDT 2025
On Mon, Mar 10, 2025 at 02:24:48PM +0100, Christoph Hellwig wrote:
> On Fri, Mar 07, 2025 at 03:26:55PM -0800, Keith Busch wrote:
> > From: Keith Busch <kbusch at kernel.org>
> >
> > The criteria for pci transports' request ready check is simpler than
> > fabrics. Move the pci check to a different function. This also makes the
> > existing ready check simpler since it doesn't need to repeatedly test if
> > the controller is a fabrics type.
>
> The change looks good, but now that this is split, the PCI version
> should move to pci.c, and the fabrics version should move to fabrics.c
> and into the nvmf_* namespace.
I don't think we can move it to pci.c. The apple device isn't fabrics
either, but is built without the pci.c module, so needs to be in a
header or common core.
More information about the Linux-nvme
mailing list