[PATCH RESEND] nvmet-tcp: get rid of a high-order allocation

Sagi Grimberg sagi at grimberg.me
Fri Jan 31 04:12:45 PST 2025



On 31/01/2025 14:09, Christoph Hellwig wrote:
> On Fri, Jan 31, 2025 at 02:05:09PM +0200, Sagi Grimberg wrote:
>> Allocating the queue commands array leads to a high order
>> allocation.
>>
>> The current size of nvmet_tcp_cmd is 704 bytes. Allocating
>> 128 of those (default queue depth) means that we are allocating
>> an array of 90K bytes. There is no reason why this will be
>> a single contiguous allocation. Change the allocation to be
>> kvcalloc instead.
> Should we still aim for non-vmalloc allocation if easily possibe,
> i.e. use kvcalloc?
>

We can do that yes...



More information about the Linux-nvme mailing list