[RFC PATCH] nvme: replace lazy sgl warn with informational message
Sagi Grimberg
sagi at grimberg.me
Fri Jan 31 00:06:24 PST 2025
On 31/01/2025 9:48, Christoph Hellwig wrote:
> On Thu, Jan 30, 2025 at 09:51:31AM -0800, Keith Busch wrote:
>> From: Keith Busch <kbusch at kernel.org>
>>
>> Instead of warning about the device's SGL capabilities the first time we
>> consider using them with a passthrough command, print out what the
>> device is capable of during initialization. While we're at it, print
>> other interesting capabilities that may be useful to know when you just
>> have a dmesg. The ouput format was inspired by other existing subsystems
>> like pci.
>>
>> And example of the new message when used with a default qemu nvme
>> emulated device:
>>
>> nvme nvme0: sgl+ meta-sgl+ sed- vwc+ apst- dsm+ wz+
> Printing out the capabilities sounds really useful. But I don't see
> how this is useful for replacing the warning about the unchecked
> passthrough?
>
I agree, I'd keep the warn_once messages.
More information about the Linux-nvme
mailing list