[PATCH] nvmet: move percpu handling into nvmet_ns_{enable,disable}

Sagi Grimberg sagi at grimberg.me
Sun Jan 26 00:04:11 PST 2025


>>
>> On 24/01/2025 10:25, hare at kernel.org wrote:
>>> From: Hannes Reinecke <hare at kernel.org>
>>>
>>> The namespace percpu counter protects pending I/O, and we can
>>> only safely diable the namespace once the counter drop to zero.
>>> So we need to init the percpu counter in nvmet_ns_enable(), and
>>> wait for it to drop to zero in nvmet_ns_disable() to avoid having
>>> I/O pending after the namespace has been disabled.
>>>
>>> Fixes: 74d16965d7ac ("nvmet-loop: avoid using mutex in IO hotpath")
>>
>> Can you please describe the bug and scenario which you are hitting 
>> this bug?
>> It is also unclear how the above patch is causing this.
>>
>>  From quick look patch itself looks reasonable.
>
> Should've said: this is the fix to the reported blktest failure
> on nvme/058...

OK, then please resend this patch that explains the exact issues that it 
solves.
Also, please rephrase your patch title to describe that this is a bug 
fix. i.e.
"nvmet: fix ...."



More information about the Linux-nvme mailing list