[RFC PATCH] nvme-fc: move tagset removal to nvme_fc_delete_ctrl()

[Ming Lei]

Hi Ewan,

On Wed, Jan 15, 2025 at 12:33:50PM -0500, Ewan Milne wrote:
> Moving the tagset removal to the end of nvme_fc_delete_ctrl() ran OK and we
> no longer see the WARN_ON() seen earlier, however I think that there is a
> potential problem with doing this because the keepalive is not stopped until
> nvme_uninit_ctrl() is called.  On our systems w/FC kato is normally disabled
> so we wouldn't see any problem but this isn't true in the general case.

Please see e9869c85c811 ("nvme-fabrics: fix kernel crash while shutting down controller")
which stops the keepalive request at the entry of
nvme_remove_admin_tag_set().

So your above concern shouldn't exist.

Thanks,
Ming