[linux-nvme:nvme-6.14 29/35] drivers/nvme/host/auth.c:742:2-3: Unneeded semicolon

[kernel test robot]

tree:   git://git.infradead.org/nvme.git nvme-6.14
head:   6d84dae9af94be43bb71d24353aef102fd0744da
commit: b68527338ba3882e43bae078c1bd4de0f55c6ce3 [29/35] nvme-tcp: request secure channel concatenation
config: arc-randconfig-r054-20250112 (https://download.01.org/0day-ci/archive/20250113/202501130310.A2dr9hU5-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501130310.A2dr9hU5-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/nvme/host/auth.c:742:2-3: Unneeded semicolon
   drivers/nvme/host/auth.c:751:2-3: Unneeded semicolon

vim +742 drivers/nvme/host/auth.c

   699	
   700	static int nvme_auth_secure_concat(struct nvme_ctrl *ctrl,
   701					   struct nvme_dhchap_queue_context *chap)
   702	{
   703		u8 *psk, *digest, *tls_psk;
   704		struct key *tls_key;
   705		size_t psk_len;
   706		int ret = 0;
   707	
   708		if (!chap->sess_key) {
   709			dev_warn(ctrl->device,
   710				 "%s: qid %d no session key negotiated\n",
   711				 __func__, chap->qid);
   712			return -ENOKEY;
   713		}
   714	
   715		if (chap->qid) {
   716			dev_warn(ctrl->device,
   717				 "qid %d: secure concatenation not supported on I/O queues\n",
   718				 chap->qid);
   719			return -EINVAL;
   720		}
   721		ret = nvme_auth_generate_psk(chap->hash_id, chap->sess_key,
   722					     chap->sess_key_len,
   723					     chap->c1, chap->c2,
   724					     chap->hash_len, &psk, &psk_len);
   725		if (ret) {
   726			dev_warn(ctrl->device,
   727				 "%s: qid %d failed to generate PSK, error %d\n",
   728				 __func__, chap->qid, ret);
   729			return ret;
   730		}
   731		dev_dbg(ctrl->device,
   732			  "%s: generated psk %*ph\n", __func__, (int)psk_len, psk);
   733	
   734		ret = nvme_auth_generate_digest(chap->hash_id, psk, psk_len,
   735						ctrl->opts->subsysnqn,
   736						ctrl->opts->host->nqn, &digest);
   737		if (ret) {
   738			dev_warn(ctrl->device,
   739				 "%s: qid %d failed to generate digest, error %d\n",
   740				 __func__, chap->qid, ret);
   741			goto out_free_psk;
 > 742		};
   743		dev_dbg(ctrl->device, "%s: generated digest %s\n",
   744			 __func__, digest);
   745		ret = nvme_auth_derive_tls_psk(chap->hash_id, psk, psk_len, digest, &tls_psk);
   746		if (ret) {
   747			dev_warn(ctrl->device,
   748				 "%s: qid %d failed to derive TLS psk, error %d\n",
   749				 __func__, chap->qid, ret);
   750			goto out_free_digest;
   751		};
   752	
   753		tls_key = nvme_tls_psk_refresh(ctrl->opts->keyring, ctrl->opts->host->nqn,
   754					       ctrl->opts->subsysnqn, chap->hash_id,
   755					       tls_psk, psk_len, digest);
   756		if (IS_ERR(tls_key)) {
   757			ret = PTR_ERR(tls_key);
   758			dev_warn(ctrl->device,
   759				 "%s: qid %d failed to insert generated key, error %d\n",
   760				 __func__, chap->qid, ret);
   761			tls_key = NULL;
   762		}
   763		kfree_sensitive(tls_psk);
   764		if (ctrl->opts->tls_key)
   765			nvme_auth_revoke_tls_key(ctrl);
   766		ctrl->opts->tls_key = tls_key;
   767	out_free_digest:
   768		kfree_sensitive(digest);
   769	out_free_psk:
   770		kfree_sensitive(psk);
   771		return ret;
   772	}
   773	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki