[PATCH 3/3] nvme: Fix queue freeze and limits lock order
Christoph Hellwig
hch at lst.de
Mon Jan 6 00:31:29 PST 2025
On Sat, Jan 04, 2025 at 10:25:22PM +0900, Damien Le Moal wrote:
> Modify the functions nvme_update_ns_info_generic(),
> nvme_update_ns_info_block() and nvme_update_ns_info() to freeze a
> namespace queue using blk_mq_freeze_queue() after starting the queue
> limits update with queue_limits_start_update() so that the queue
> freezing is always done after obtaining the device queue limits lock (as
> per the block layer convention for sysfs attributes).
FYI, there's a few more like this. In my WIP series I've basically
made the normal queue_limits_commit_update contain the freeze and add
a special version without the freeze, which makes a lot of this
more obvious. Let me dust it off even before sorting out the poll
flag so that we have a little more discussion material.
More information about the Linux-nvme
mailing list